UBBC Wrapper/Smiley Adder [JS]

[Peter]

This code might look familiar to some coders, that's because it is the ProBoards UBBC wrapper, which I wrote for ProBoards.

What it does is wraps tags around the selected text in the textarea, and can also be used for smileys. Could be useful for comment systems, forums (like ProBoards) for example.

<script type="text/javascript">
<!--

function ubbc(open, end){
    var tArea = document.THE_FORM.TEXTAREA;
    var isIE = (document.all)? true : false;
    var open = (open)? open : "";
    var end = (end)? end : "";

    if(isIE){
       tArea.focus();
       var curSelect = document.selection.createRange();
       if(arguments[2]){
          curSelect.text = open + arguments[2] + "]" + curSelect.text + end;
       } else {
          curSelect.text = open + curSelect.text + end;
       }
    } else if(!isIE && typeof tArea.selectionStart != "undefined"){
       var selStart = tArea.value.substr(0, tArea.selectionStart);
       var selEnd = tArea.value.substr(tArea.selectionEnd, tArea.value.length);
       var curSelection = tArea.value.replace(selStart, '').replace(selEnd, '');
       if(arguments[2]){
          tArea.value = selStart + open + arguments[2] + "]" + curSelection + end + selEnd;
       } else {
          tArea.value = selStart + open + curSelection + end + selEnd;
       }
    } else {
       tArea.value += (arguments[2])? open + arguments[2] + "]" + end : open + end;
    }
}

//-->
</script>

Only line you need to change is this...

var tArea = document.THE_FORM.TEXTAREA;

...that needs to point to your form textarea.

Example: if I wanted to have bold tags, I would do this....

<a href="#" onclick="ubbc('[b]', '[/b]')">Bold</a>

You can also add tags that don't have a closing tag. Like so...

<a href="#" onclick="ubbc('[hr]')">HR Line</a>

[california]

There's something here which I don't understand, and I noticed this quite a while ago when looking at the PB coding:

} else {
tArea.value += (arguments[2])? open + arguments[2] + "]" + end : open + end;
}

This last else, it doesn't belong. You have:

if(isIE){
...
}else if(!isIE){
...
}else{
...
}

But that doesn't make sense. Obviously isIE is either going to be true or false. If it's true, the first block will execute. If it's false, the second block will execute. When will the third block:

tArea.value += (arguments[2])? open + arguments[2] + "]" + end : open + end;

execute? It won't, it can't. Seems like it should be removed and this:

} else if(!isIE){

would just be:

} else {

if I'm not missing something.

[Peter]

Yeah, it is something I forgot to fix up, but it wasn't important at the time, so I never bothered to send an updated script to Pat. It was ment to be for browsers that didn't support ranges, but the !isIE was ment to be checking for Mozilla. I just missed it this time. I'll remove it from it now

[california]

From what I've heard, it doesn't work in Safari. It duplicates the entire post when you click a smiley. Or was it meant to be used for smileys?

[.hp_pickle]

I dont think smilies works in safari... or maybe it does I don't know.

[Peter]

czabs said:

From what I've heard, it doesn't work in Safari. It duplicates the entire post when you click a smiley. Or was it meant to be used for smileys?

It can be used for smileys as well, this is why I had that last if statement, it was ment to add tags or smileys to the end of the post if the browser didn't support the other methods.

Browsers it should work in - IE, FF, NN, and Opera

[edit] There we go, have added in that last statement