Most Pointless Code Written

[mrsmiley]

Well, I'm sure in all our noob days we've written enormous codes completing tasks which could have been optimized to a fifth as big. Here's a thread to post some of yours!

This is one I made a while back, when I first visited Proboards. It was a simple category splitter, yet horrible coded. Fun to read up on now, hehe!


<sub><script type='text/javascript'>
<!--
/*============================
------------------------------
Category Splitter w/ Optional Head/base Images
------------------------------
=============================*/

var head = ["yes" , "" , "50px"];
var base = ["no" , "" , "50px"];
var gap = "50px";


var gCell = document.getElementsByTagName('table');
var Ltable = "";
var data;


var gHead = '<tr rowSpan="3"><td colSpan="5" width="100%"><img src="' + head[1] + '" height="' + head[2] + '" width="100%"/></td></tr>';
var gBottom = '<tr rowSpan="3"><td colSpan="5" width="100%"><img src="' + base[1] + '" height="' + base[2] + '" width="100%"/></td></tr>';
var gDiv = '<div style="height: ' + gap + ';"></div>';


if(window.location.href.match(/\.com(\/(index\.cgi(#\w+|\?(action=home)?)?)?)?$/)){
for(x = 0; x < gCell.length; x++){
if(gCell[x].cellPadding == "4" && gCell[x].cellSpacing == "1" && gCell[x].innerHTML.indexOf("Info Center") == -1){
tTal = gCell[x];
tTal.parentNode.parentNode.parentNode.backgroundColor = "transparent";
forumBar = gCell[x].firstChild.firstChild.cloneNode(true);
for(r = 0; r < gCell[x].cells.length; r++){
if(gCell[x].cells[r].colSpan == "5" && gCell[x].cells[r].height == "18" && gCell[x].cells[r].innerHTML.indexOf("markallboardsread") != -1){
var markBoard = gCell[x].cells[r].firstChild.innerHTML;
}
}
for(t = 0; t < gCell[x].cells.length; t++){
if(gCell[x].cells[t].colSpan == "5" && gCell[x].cells[t].height == "18" && gCell[x].cells[t].innerHTML.indexOf("markallboardsread") == -1){
var telkj = gCell[x].innerHTML.split(gCell[x].cells[t].parentNode.innerHTML)[1]
var lkjl = telkj.split('<TD class=catbg')[0];
lkjl+= "<td class='windowbg' colspan='5' align='right'>" + markBoard + "</td></TR>";
Ltable+='<table cellspacing="0" cellpadding="0" class="trans" width="100%">';
if(head[0].match(/yes/i)){
Ltable+= gHead;
}
Ltable+= "<table id='splitz' border='0' width='100%' cellspacing='1' cellpadding='4' class='bordercolor'>";
Ltable+= "<tr>";
Ltable+= forumBar.innerHTML;
Ltable+= "</tr>";
Ltable+= "<tr><td colspan='5' class='catbg' height='18'>";
Ltable+= gCell[x].cells[t].innerHTML;
Ltable+= "</td></tr>";
Ltable+= lkjl;
Ltable+= "</table>";
if(base[0].match(/yes/i)){
Ltable+= gBottom;
}
Ltable+= gDiv;
Ltable+="</table>";
}
}
}
}
var dDiv = document.createElement('div');
dDiv.innerHTML = Ltable;
dDiv.backgroundColor = "transparent";
tTal.style.display = "none";
var gRow = tTal.parentNode.parentNode.parentNode.insertRow(0);
gRow.rowSpan = "3";
gRow.width = "100%";
gRow.backgroundColor = "transparent";
var gCel = gRow.insertCell(0);
gCel.colSpan = "5";
gCel.width = "100%";
gCel.backgroundColor = "transparent";
gCel.innerHTML = Ltable;
gCell[5].backGround = "transparent";
gCell[5].className = "trans";
}



//-->
</script></sub>

[electricwwx]

Hmm, it's probably between, the pointless (2005):


<script>
//Mode Settings (Mode 1 = Normal, Mode 2 = Gallery View)
if(location.href.match(/mode=2/i)){
document.write('</div>')
document.write('<TABLE align="center" width="92%" cellpadding="6" cellspacing="0" border="0" style="border: 1px solid #5E7B9D"><tr><td class="titlebg" width="100%" vAlign="middle" align="center" style="border-bottom: 1px solid #5E7B9D"><b>General Board</b></td></tr><tr><td width="100%" vAlign="middle" align="center" class="windowbg"><table id="dropcell" border=0 cellspacing=0 cellpadding=6 width=100%><tr></tr></table></td></tr></TABLE><br />')
var iCurTable = document.getElementById('maintable').getElementsByTagName('TABLE')[6].rows
var num = 0
var num2 = 0
for(i=1;i<iCurTable.length;i++){
if(iCurTable[i].cells.length > 6){
var iRow = document.getElementById('dropcell').rows[num2]
iRow.insertCell(document.getElementById('dropcell').rows[num2].cells.length)
iRow.cells[num].width="25%"
iRow.cells[num].innerHTML +="<center>" + iCurTable[i].cells[1].innerHTML + "</center>" + iCurTable[i].cells[2].innerHTML + "<BR /><i>Started By: </i>" + iCurTable[i].cells[3].innerHTML + "<BR /><i>Last Reply: </i>" + iCurTable[i].cells[6].innerHTML.split(/<br>/i)[0] +"<BR />Replies: " + iCurTable[i].cells[4].innerHTML.replace(/size=2/gi,"size=1") + "<BR />Views: " + iCurTable[i].cells[5].innerHTML.replace(/size=2/gi,"size=1") + "<BR /><BR />"
num++
if(num==4){ num=0; num2++; document.getElementById('dropcell').insertRow(document.getElementById('dropcell').rows.length) }
}}

//add post bar
var iCell = document.getElementById('dropcell').insertRow(num2+1).insertCell(0)
iCell.colSpan="4";
iCell.innerHTML= '<div style="float: left;">' + document.getElementById('maintable').getElementsByTagName('TABLE')[4].rows[0].cells[1].innerHTML + "<a href='javascript:createCookie(2)'>[Always Use Mode 2]</a> <a href='javascript:createCookie(0)'>[Clear Mode Cookie]</a></div>"
iCell.style.borderTop="1px solid #D0D0D0"

var B = document.getElementById('maintable').getElementsByTagName('TABLE')[4].rows[0].cells[0].getElementsByTagName("B");
var A = document.getElementById('maintable').getElementsByTagName('TABLE')[4].rows[0].cells[0].getElementsByTagName("A");

iCell.innerHTML += '<div vAlign="bottom" style="float: right; margin-top: 5px;">' + B[0].innerHTML +' <select onChange="if(this.options[this.selectedIndex].value) window.location=this.options[this.selectedIndex].value;"><option selected>'+ B[1].innerHTML +'</option>';
for(i = 1; 1 < A.length; i++){
iCell.innerHTMl += '<option value="'+A[i].href+'">' + A[i].innerHTML +'</option>';
}
iCell.innerHTML += '</select></div>';
}

function createCookie(modal){
document.cookie="usemode=" + modal
}
</script>


And the over-use of brackets (2002-2003):


<script>
if (location.href.indexOf("action=display") != -1){
//Created by Webworldx - CF
//Codebase = v1.7b
var correct = document.getElementsByTagName('td');
for(a=0;a<correct.length;a++){
if (correct[a].width=="20%") {
if (correct[a].innerHTML.match("Author")) {
} else {
if (correct[a].innerHTML.match("Total Votes:")) {
} else {
var FindPostCount = correct[a].innerHTML
if (FindPostCount.match("Guest")) {
} else {
FindPostCount = FindPostCount.split("Posts: ")
FindPostCount = FindPostCount[1].split("< BR>")
var CheckEXP = FindPostCount[0]
var EXP = FindPostCount[0]

var STR;
var MAG;
var DEF;
var Level;

Level=parseInt(EXP/15)

if (EXP >= 10) {
STR = EXP - 5;
MAG = parseInt(EXP /2);
DEF = parseInt((2/3) *(EXP - 10));
} else {
STR=0;
MAG=0;
DEF=0;
}

if (EXP >= 1500) {
EXP = 1500;
STR = 1500;
MAG = 1500;
DEF = 1500;
}

var embedRPG = "<laugh align=left><b>EXP: </b><font color=000080><i>" + parseInt(EXP) + "</i></font>< BR><table width=100 border=1><tr><td><img src=http://www.suddenlaunch2.com/boardimages/CatBgs.jpg width=" + EXP/10 + " height=10 alt=" + EXP + "></td></tr></table><b>STR: </b><font color=000080><i>" + parseInt(STR) + "</i></font><table width=100 border=1><tr><td><img src=http://members.lycos.co.uk/slwebworldx/inspire/Crazy/bhg.gif width=" + STR/10 + " height=10 alt=" + STR + "></td></tr></table><b>MAG: </b><font color=000080><i>" + parseInt(MAG) + "</i></font><table width=100 border=1><tr><td><img src=http://members.lycos.co.uk/slwebworldx/inspire/Crazy/bmg.gif width=" + MAG/10 + " height=10 alt=" + MAG + "></td></tr></table><b>grinEF: </b><font color=000080><i>" + parseInt(DEF) + "</i></font><table width=100 border=1><tr><td><img src=http://members.lycos.co.uk/slwebworldx/inspire/Crazy/bxg.gif width=" + DEF/10 + " height=10 alt=" + DEF + "></td></tr></table>< BR><b>Level: </b><font color=#FF0000>" + Level + "</font></p>";
correct[a].innerHTML=correct[a].innerHTML.replace('Posts: ' + CheckEXP,embedRPG)
}
}
}
}
}
}
</script>


[mrsmiley]

Haha, I love that second one!

[electricwwx]

Cheers! It was six years ago or so now though, and horribly written by today's standards =) Anyone else care to share?!